public/foundryvtt-shadows-over-sol
0
0
Fork 0
Code Issues Pull Requests Projects Releases 12 Wiki Activity

Infinite loop when reseting just the deck on FoundryVTT V9 #9

New Issue
Closed
opened 2022-03-17 22:11:55 +01:00 by shawnlkelley · 3 comments
shawnlkelley commented 2022-03-17 22:11:55 +01:00 (Migrated from gitlab.com)
Copy Link

I am currently testing this module for an upcoming game and I have run into an issue where when using "Reset Deck Only" on the character sheet the system goes into an infinite loop and locks up, and I have to wait for the browser to catch the long-running script and then reload the page. I have tested this on Firefox and one of my players who is helping me test has tried it on Chrome to the same effect. When debugging, I was able to pin it down to the resetDeck method in sos-card-deck.js

I am currently testing this module for an upcoming game and I have run into an issue where when using "Reset Deck Only" on the character sheet the system goes into an infinite loop and locks up, and I have to wait for the browser to catch the long-running script and then reload the page. I have tested this on Firefox and one of my players who is helping me test has tried it on Chrome to the same effect. When debugging, I was able to pin it down to the resetDeck method in sos-card-deck.js
LeRatierBretonnien commented 2022-03-18 19:21:42 +01:00 (Migrated from gitlab.com)
Copy Link

I will heck tonight

I will heck tonight
LeRatierBretonnien commented 2022-03-18 19:30:25 +01:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 633525a9e5

mentioned in commit 633525a9e56be1fb2f8270c6902b822dde1e61bd
LeRatierBretonnien commented 2022-03-18 19:30:37 +01:00 (Migrated from gitlab.com)
Copy Link

Fixed in 2.0.5 ! Thanks for reporting the bug

Fixed in 2.0.5 ! Thanks for reporting the bug
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: public/foundryvtt-shadows-over-sol#9
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?