public/fvtt-hero-system-6
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 40 Wiki Activity

skill levels being added to skills incorrectly #2

New Issue
Closed
opened 2023-08-26 19:50:48 +02:00 by techogre · 3 comments
techogre commented 2023-08-26 19:50:48 +02:00
Copy Link

Foundry 11.308
HERO 11.0.16

Seemingly random skill levels being added to skills. To recreate:

  1. Drag skill from compendium to character sheet.
  2. Edit the skill.
  3. Click on Details tab, the Levels box is blank.
  4. Click "Familiarity only" box
  5. Click "Everyman skill" box
  6. "Levels" now has an 8 in it. Effective skill is now 16-.
Foundry 11.308 HERO 11.0.16 Seemingly random skill levels being added to skills. To recreate: 1. Drag skill from compendium to character sheet. 2. Edit the skill. 3. Click on Details tab, the Levels box is blank. 4. Click "Familiarity only" box 5. Click "Everyman skill" box 6. "Levels" now has an 8 in it. Effective skill is now 16-.
uberwald commented 2023-08-26 20:29:59 +02:00
Owner
Copy Link

OK, but I don't understand the issue. *
Could you please post snapshot and the expected result, I do not get what must be done here.

OK, but I don't understand the issue. * Could you please post snapshot and the expected result, I do not get what must be done here.
legendsmiths commented 2023-08-26 20:44:48 +02:00
Collaborator
Copy Link

Familiarity should set the skill roll to 8-. Cost = 1
Proficiency should set the skill roll to 10-. Cost = 2
Everyman should set the cost to 0.

Familiarity can only be combined with Everyman.
Proficiency is exclusive.

Right now when you check Familiarity it sets Levels to 10, which then get added to the base roll (Levels should be 0)
clicking Everyman after that, sets Levels to 8, which then get added to the base roll (Levels should be 0)

Familiarity should set the skill roll to 8-. Cost = 1 Proficiency should set the skill roll to 10-. Cost = 2 Everyman should set the cost to 0. Familiarity can only be combined with Everyman. Proficiency is exclusive. Right now when you check Familiarity it sets Levels to 10, which then get added to the base roll (Levels should be 0) clicking Everyman after that, sets Levels to 8, which then get added to the base roll (Levels should be 0)
uberwald referenced this issue from a commit 2023-08-26 20:59:45 +02:00
#2 Fix skill profiency
uberwald commented 2023-08-26 21:00:02 +02:00
Owner
Copy Link

Fixed for next release

Fixed for next release
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: public/fvtt-hero-system-6#2
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?